Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2347#discussion_r191403062
  
    --- Diff: 
store/sdk/src/main/java/org/apache/carbondata/sdk/file/AvroCarbonWriter.java ---
    @@ -177,13 +198,26 @@ private static Field prepareFields(Schema.Field 
avroField) {
         String FieldName = avroField.name();
         Schema childSchema = avroField.schema();
         Schema.Type type = childSchema.getType();
    +    LogicalType logicalType = childSchema.getLogicalType();
         switch (type) {
           case BOOLEAN:
             return new Field(FieldName, DataTypes.BOOLEAN);
           case INT:
    -        return new Field(FieldName, DataTypes.INT);
    +        if (logicalType instanceof LogicalTypes.Date) {
    +          return new Field(FieldName, DataTypes.DATE);
    +        } else {
    +          LOGGER.warn("Unsupported logical type. Considering Data Type as 
INT for " + childSchema
    +              .getName());
    +          return new Field(FieldName, DataTypes.INT);
    +        }
           case LONG:
    -        return new Field(FieldName, DataTypes.LONG);
    +        if (logicalType instanceof LogicalTypes.TimestampMillis) {
    --- End diff --
    
    Don't we have to check the TimeStampMicros and TimeStamp logicaltypes 


---

Reply via email to