[GitHub] carbondata pull request #2347: [CARBONDATA-2554] Added support for logical t...

[sounakr]

Github user sounakr commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2347#discussion_r191396859
  
    --- Diff: 
processing/src/main/java/org/apache/carbondata/processing/datatypes/PrimitiveDataType.java
 ---
    @@ -288,7 +288,12 @@ public int getSurrogateIndex() {
               logHolder.setReason(message);
             }
           } else {
    -        surrogateKey = dictionaryGenerator.getOrGenerateKey(parsedValue);
    +        if (dictionaryGenerator instanceof DirectDictionary
    +            && input instanceof Long) {
    --- End diff --
    
    Rectify the indentation.


---