Github user sounakr commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2347#discussion_r191399826
--- Diff:
processing/src/main/java/org/apache/carbondata/processing/loading/steps/InputProcessorStepWithNoConverterImpl.java
---
@@ -313,7 +315,22 @@ private CarbonRowBatch getBatch() {
throw new CarbonDataLoadingException("Loading Exception", e);
}
} else {
- newData[i] = data[orderOfData[i]];
+ DataType dataType = dataFields[i].getColumn().getDataType();
+ if (dataType == DataTypes.DATE && data[orderOfData[i]]
instanceof Long) {
+ DirectDictionaryGenerator directDictionaryGenerator =
--- End diff --
why everytime a new directDictionaryGenerator object is needed? It can also
be a member variable of InputProcessorStepWithNoConverterImpl and initialize
only once.
---
