Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2662#discussion_r214504750
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/blocklet/BlockletEncodedColumnPage.java
---
@@ -105,8 +112,15 @@ void addEncodedColumnColumnPage(EncodedColumnPage
encodedColumnPage) {
LOGGER.info(
"Local dictionary Fallback is initiated for column: " +
this.columnName + " for page:"
+ encodedColumnPageList.size());
- fallbackFutureQueue.add(fallbackExecutorService
- .submit(new FallbackColumnPageEncoder(encodedColumnPage,
encodedColumnPageList.size())));
+ if (isDecoderBasedFallBackEnabled) {
--- End diff --
Move this code to some private metod and pass encodedColumnPage and
pageIndex
---
