[GitHub] carbondata pull request #2662: [WIP][CARBONDATA-2889]Add decoder based fallb...

[kumarvishal09]

Github user kumarvishal09 commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2662#discussion_r214505217
  
    --- Diff: 
core/src/main/java/org/apache/carbondata/core/datastore/blocklet/BlockletEncodedColumnPage.java
 ---
    @@ -86,7 +92,8 @@
        * @param encodedColumnPage
        * encoded column page
        */
    -  void addEncodedColumnColumnPage(EncodedColumnPage encodedColumnPage) {
    +  void addEncodedColumnColumnPage(EncodedColumnPage encodedColumnPage,
    +      LocalDictionaryGenerator localDictionaryGenerator) {
    --- End diff --
    
    better to add local dictionary generator in constructor


---