Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2662#discussion_r214505230
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/FallbackActualDataBasedColumnPageEncoder.java
---
@@ -19,17 +19,17 @@
import java.util.concurrent.Callable;
import org.apache.carbondata.core.datastore.TableSpec;
-import
org.apache.carbondata.core.datastore.page.encoding.ColumnPageEncoder;
-import
org.apache.carbondata.core.datastore.page.encoding.DefaultEncodingFactory;
import
org.apache.carbondata.core.datastore.page.encoding.EncodedColumnPage;
+import org.apache.carbondata.core.util.CarbonUtil;
/**
* Below class will be used to encode column pages for which local
dictionary was generated
* but all the pages in blocklet was not encoded with local dictionary.
* This is required as all the pages of a column in blocklet either it
will be local dictionary
* encoded or without local dictionary encoded.
*/
-public class FallbackColumnPageEncoder implements
Callable<FallbackEncodedColumnPage> {
+public class FallbackActualDataBasedColumnPageEncoder
--- End diff --
Change class name to ActualDataBasedFallbackEncoder
---
