Github user kumarvishal09 commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2662#discussion_r214545340
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/blocklet/EncodedBlocklet.java
---
@@ -110,21 +120,24 @@ private void addEncodedMeasurePage(EncodedTablePage
encodedTablePage) {
* @param encodedTablePage
* encoded table page
*/
- private void addEncodedDimensionPage(EncodedTablePage encodedTablePage) {
+ private void addEncodedDimensionPage(EncodedTablePage encodedTablePage,
+ Map<String, LocalDictionaryGenerator> localDictionaryGeneratorMap) {
--- End diff --
Local dictionary map instance will not change and EncodedBlocklet instance
is created only once, better to pass in constructor
---
