Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r227616799
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/chunk/impl/VariableLengthDimensionColumnPage.java
---
@@ -54,10 +75,15 @@ public VariableLengthDimensionColumnPage(byte[]
dataChunks, int[] invertedIndex,
}
dataChunkStore = DimensionChunkStoreFactory.INSTANCE
.getDimensionChunkStore(0, isExplicitSorted, numberOfRows,
totalSize, dimStoreType,
- dictionary);
- dataChunkStore.putArray(invertedIndex, invertedIndexReverse,
dataChunks);
+ dictionary, vectorInfo != null);
+ if (vectorInfo != null) {
+ dataChunkStore.fillVector(invertedIndex, invertedIndexReverse,
dataChunks, vectorInfo);
+ } else {
+ dataChunkStore.putArray(invertedIndex, invertedIndexReverse,
dataChunks);
+ }
}
+
--- End diff --
remove this
---