Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r227618507
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/ColumnPageDecoder.java
---
@@ -29,6 +31,12 @@
*/
ColumnPage decode(byte[] input, int offset, int length) throws
MemoryException, IOException;
+ /**
+ * Apply decoding algorithm on input byte array and fill the vector
here.
+ */
+ void decodeAndFillVector(byte[] input, int offset, int length,
ColumnVectorInfo vectorInfo,
+ BitSet nullBits, boolean isLVEncoded) throws MemoryException,
IOException;
--- End diff --
I feel it is not good to add `isLVEncoded` just for LVEncoded, can we pass
a more generic parameter, since this is a common class for all Decoder
---
