Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r227618222
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/encoding/EncodingFactory.java
---
@@ -66,6 +66,14 @@ public abstract ColumnPageEncoder
createEncoder(TableSpec.ColumnSpec columnSpec,
*/
public ColumnPageDecoder createDecoder(List<Encoding> encodings,
List<ByteBuffer> encoderMetas,
String compressor) throws IOException {
+ return createDecoder(encodings, encoderMetas, compressor, false);
+ }
+
+ /**
+ * Return new decoder based on encoder metadata read from file
--- End diff --
In the comment, can you describe what is the behavior when `fullVectorFill`
is true?
---
