Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2819#discussion_r227618017
--- Diff:
core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java
---
@@ -176,7 +179,7 @@ private static ColumnPage
getDecimalColumnPage(TableSpec.ColumnSpec columnSpec,
rowOffset.putInt(counter, offset);
VarLengthColumnPageBase page;
- if (unsafe) {
+ if (unsafe && !meta.isFillCompleteVector()) {
--- End diff --
many place check like this, can we make a function for it and make it more
readable by give proper function name?
---
