Github user ajantha-bhat commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3001#discussion_r243951568
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java
 ---
    @@ -95,6 +95,9 @@ private CarbonColumnVectorImpl 
createDirectStreamReader(int batchSize, DataType
         } else if (dataType == DataTypes.STRING) {
           return new SliceStreamReader(batchSize, field.getDataType(), 
dictionaryBlock);
         } else if (DataTypes.isDecimal(dataType)) {
    +      if (dictionary != null && dataType instanceof DecimalType) {
    --- End diff --
    
    If inside DataTypes.isDecimal check means, it is Decimal type. 
    So, why this change required ?


---

Reply via email to