Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3001#discussion_r244095118
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbondataPageSourceProvider.java
 ---
    @@ -79,13 +80,31 @@
       @Override
       public ConnectorPageSource createPageSource(ConnectorTransactionHandle 
transactionHandle,
           ConnectorSession session, ConnectorSplit split, List<ColumnHandle> 
columns) {
    -    this.queryId = ((CarbondataSplit)split).getQueryId();
    +    CarbondataSplit carbondataSplit = (CarbondataSplit) split;
    --- End diff --
    
    Not expecting any changes in presto implementations, Changes should be only 
present in `PrestoCarbonVectorizedRecordReader` or 
`org.apache.carbondata.presto.CarbonVectorBatch`. Because these are reader 
classes why changes needed here.


---

Reply via email to