Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3001#discussion_r244093200
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/CarbonVectorBatch.java
 ---
    @@ -95,6 +95,9 @@ private CarbonColumnVectorImpl 
createDirectStreamReader(int batchSize, DataType
         } else if (dataType == DataTypes.STRING) {
           return new SliceStreamReader(batchSize, field.getDataType(), 
dictionaryBlock);
         } else if (DataTypes.isDecimal(dataType)) {
    +      if (dictionary != null && dataType instanceof DecimalType) {
    +        return new DecimalSliceStreamReader(batchSize, (DecimalType) 
dataType, dictionary);
    +      }
    --- End diff --
    
    I am not sure why this change is required? Can you explain?


---

Reply via email to