Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/3001#discussion_r244095288
  
    --- Diff: 
integration/presto/src/main/java/org/apache/carbondata/presto/readers/BooleanStreamReader.java
 ---
    @@ -86,4 +86,15 @@ public BooleanStreamReader(int batchSize, DataType 
dataType, Dictionary dictiona
         builder = type.createBlockBuilder(null, batchSize);
       }
     
    +  @Override public void putObject(int rowId, Object value) {
    --- End diff --
    
    Already it has methods to handle put why added methods again in all 
readers. I don't think these changes required in all readers


---

Reply via email to