akashrn5 commented on a change in pull request #3645: [CARBONDATA-3728] Fix
insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386199857
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
##########
@@ -457,6 +534,34 @@ public static boolean isHeaderValid(String tableName,
String[] csvHeader,
return noDictSortAndNoSortTypes;
}
+ /**
+ * Get the data types of the no dictionary sort columns as per dataFields
order
Review comment:
i agree, but atleast for the methods which you ave written better to
avoid,and the existing one we can have a refactor PR later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
