ajantha-bhat commented on a change in pull request #3645: [CARBONDATA-3728] Fix
insert failure on partition table with local sort
URL: https://github.com/apache/carbondata/pull/3645#discussion_r386205170
##########
File path:
processing/src/main/java/org/apache/carbondata/processing/util/CarbonDataProcessorUtil.java
##########
@@ -457,6 +534,34 @@ public static boolean isHeaderValid(String tableName,
String[] csvHeader,
return noDictSortAndNoSortTypes;
}
+ /**
+ * Get the data types of the no dictionary sort columns as per dataFields
order
Review comment:
I have analyzed already, The caller needs nodict mapping, I cannot change my
functions. Then caller functions become non-readable. Later we have to refactor
sort step and other places freshly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
