Indhumathi27 commented on a change in pull request #3620: [CARBONDATA-3700]
Optimize pruning performance when prunning with multi…
URL: https://github.com/apache/carbondata/pull/3620#discussion_r387530433
##########
File path:
core/src/main/java/org/apache/carbondata/core/datamap/TableDataMap.java
##########
@@ -302,19 +323,29 @@ public Void call() throws IOException {
segmentPropertiesFetcher.getSegmentPropertiesFromDataMap(dataMapList.get(0));
Segment segment = segmentDataMapGroup.getSegment();
if (filter.isResolvedOnSegment(segmentProperties)) {
+ FilterExecuter filterExecuter = FilterUtil
+ .getFilterExecuterTree(filter.getResolver(),
segmentProperties,
+ null, table.getMinMaxCacheColumns(segmentProperties),
+ false);
for (int i = segmentDataMapGroup.getFromIndex();
i <= segmentDataMapGroup.getToIndex(); i++) {
List<Blocklet> dmPruneBlocklets = dataMapList.get(i).prune(
- filter.getResolver(), segmentProperties, partitions);
+ filter.getResolver(), segmentProperties, partitions,
filterExecuter);
pruneBlocklets.addAll(addSegmentId(
blockletDetailsFetcher.getExtendedBlocklets(dmPruneBlocklets, segment),
segment));
}
} else {
+ FilterExecuter filterExecuter = FilterUtil
+ .getFilterExecuterTree(new DataMapFilter(segmentProperties,
table,
+ filter.getNewCopyOfExpression()).getResolver(),
segmentProperties,
+ null, table.getMinMaxCacheColumns(segmentProperties),
+ false);
for (int i = segmentDataMapGroup.getFromIndex();
i <= segmentDataMapGroup.getToIndex(); i++) {
List<Blocklet> dmPruneBlocklets = dataMapList.get(i).prune(
- filter.getNewCopyOfExpression(), segmentProperties,
partitions, table);
+ filter.getNewCopyOfExpression(), segmentProperties,
partitions, table,
Review comment:
Avoid deserializing ` filter.getNewCopyOfExpression()` again, as already
done in line:341, can reuse the same
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
