Indhumathi27 commented on a change in pull request #3620: [CARBONDATA-3700]
Optimize pruning performance when prunning with multi…
URL: https://github.com/apache/carbondata/pull/3620#discussion_r387534591
##########
File path:
core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentProperties.java
##########
@@ -147,6 +173,27 @@ private void fillBlockToDimensionOrdinalMapping() {
}
}
+ /**
+ * compare the segmentproperties based on fingerprinter
+ */
+ @Override
+ public boolean equals(Object obj) {
+ if (!(obj instanceof SegmentProperties)) {
+ return false;
+ }
+ if (this.getNumberOfColumns() != ((SegmentProperties)
obj).getNumberOfColumns()) {
+ return false;
+ }
+ return getFingerprinter() != Long.MIN_VALUE &&
+ ((SegmentProperties) obj).getFingerprinter() != Long.MIN_VALUE &&
Review comment:
Assign (SegmentProperties) obj) to a variable and reuse to avoid cast
overhead
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
