niuge01 commented on a change in pull request #3620: [CARBONDATA-3700] Optimize
pruning performance when prunning with multi…
URL: https://github.com/apache/carbondata/pull/3620#discussion_r387568150
##########
File path:
core/src/main/java/org/apache/carbondata/core/util/CarbonProperties.java
##########
@@ -1843,6 +1846,33 @@ public static int getNumOfThreadsForPruning() {
return numOfThreadsForPruning;
}
+ /**
+ * This method validates the driverPruningMultiThreadEnableFilesCount
+ */
+ public static int getDriverPruningMultiThreadEnableFilesCount() {
+ int driverPruningMultiThreadEnableFilesCount =
Integer.parseInt(CarbonProperties.getInstance()
+
.getProperty(CarbonCommonConstants.CARBON_DRIVER_PRUNING_MULTI_THREAD_ENABLE_FILES_COUNT,
+
CarbonCommonConstants.CARBON_DRIVER_PRUNING_MULTI_THREAD_ENABLE_FILES_COUNT_DEFAULT));
+ try {
+ if (driverPruningMultiThreadEnableFilesCount <= 0) {
+ LOGGER.info("The driver prunning multithread enable files count value
\""
+ + driverPruningMultiThreadEnableFilesCount
+ + "\" is invalid. Using the default value \""
+ +
CarbonCommonConstants.CARBON_DRIVER_PRUNING_MULTI_THREAD_ENABLE_FILES_COUNT_DEFAULT);
+ driverPruningMultiThreadEnableFilesCount =
Integer.parseInt(CarbonCommonConstants
+ .CARBON_DRIVER_PRUNING_MULTI_THREAD_ENABLE_FILES_COUNT_DEFAULT);
Review comment:
Can define CARBON_DRIVER_PRUNING_MULTI_THREAD_ENABLE_FILES_COUNT_DEFAULT as
int field directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
