niuge01 commented on a change in pull request #3620: [CARBONDATA-3700] Optimize
pruning performance when prunning with multi…
URL: https://github.com/apache/carbondata/pull/3620#discussion_r387556468
##########
File path:
core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
##########
@@ -686,6 +685,11 @@ public long getRowCount(Segment segment,
List<PartitionSpec> partitions) {
boolean[] minMaxFlag = getMinMaxFlag(row, BLOCK_MIN_MAX_FLAG);
String fileName = getFileNameWithFilePath(row, filePath);
short blockletId = getBlockletId(row);
+ if (!validateSegmentProperties(segmentProperties)) {
Review comment:
Validate segment properties and build filter executer each times in loop?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
