cfmcgrady commented on code in PR #1848:
URL:
https://github.com/apache/incubator-celeborn/pull/1848#discussion_r1307239837
##########
common/src/main/java/org/apache/celeborn/common/meta/FileInfo.java:
##########
@@ -114,7 +114,7 @@ public long getFileLength() {
return bytesFlushed;
}
- public long updateBytesFlushed(int numBytes) {
+ public long updateBytesFlushed(long numBytes) {
Review Comment:
~~that's why the `testLargeFile` failed before.~~ cc @waitinfuture
##########
common/src/main/java/org/apache/celeborn/common/meta/FileInfo.java:
##########
@@ -114,7 +114,7 @@ public long getFileLength() {
return bytesFlushed;
}
- public long updateBytesFlushed(int numBytes) {
+ public long updateBytesFlushed(long numBytes) {
Review Comment:
~~that's why the `testLargeFile` failed before. ~~ cc @waitinfuture
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
