cfmcgrady commented on code in PR #1848:
URL:
https://github.com/apache/incubator-celeborn/pull/1848#discussion_r1308122944
##########
worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorterSuiteJ.java:
##########
@@ -102,15 +99,12 @@ public void prepare(boolean largefile) throws IOException {
while (buf2.hasRemaining()) {
channel.write(buf2);
}
+ partitionSize[mapId] = partitionSize[mapId] + batchHeader.length +
mockedData.length;
}
originFileLen = channel.size();
fileInfo.getChunkOffsets().add(originFileLen);
- fileInfo.updateBytesFlushed((int) originFileLen);
Review Comment:
that's why the `testLargeFile` failed before. the created file is larger
than 2GB, which is bigger than what `Integer.MAX_VALUE` can handle. cc
@waitinfuture @FMX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
