waitinfuture commented on code in PR #1848:
URL:
https://github.com/apache/incubator-celeborn/pull/1848#discussion_r1308532204
##########
worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorterSuiteJ.java:
##########
@@ -87,6 +83,7 @@ public void prepare(boolean largefile) throws IOException {
}
return v;
});
+ // [63.9k, 192k + 63.9k]
Review Comment:
I think this is to make sure that dataSize will not exceed 256k, the default
flush threshold.
##########
worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorterSuiteJ.java:
##########
@@ -102,15 +99,12 @@ public void prepare(boolean largefile) throws IOException {
while (buf2.hasRemaining()) {
channel.write(buf2);
}
+ partitionSize[mapId] = partitionSize[mapId] + batchHeader.length +
mockedData.length;
}
originFileLen = channel.size();
fileInfo.getChunkOffsets().add(originFileLen);
- fileInfo.updateBytesFlushed((int) originFileLen);
Review Comment:
Good catch! Since `dataSize` is random, it happens randomly that the file
exceeds 2G.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
