waitinfuture commented on code in PR #1848:
URL:
https://github.com/apache/incubator-celeborn/pull/1848#discussion_r1308545370
##########
worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorterSuiteJ.java:
##########
@@ -102,15 +99,12 @@ public void prepare(boolean largefile) throws IOException {
while (buf2.hasRemaining()) {
channel.write(buf2);
}
+ partitionSize[mapId] = partitionSize[mapId] + batchHeader.length +
mockedData.length;
}
originFileLen = channel.size();
fileInfo.getChunkOffsets().add(originFileLen);
- fileInfo.updateBytesFlushed((int) originFileLen);
Review Comment:
Although IMO, in reality it will not happen because `updateBytesFlushed` is
passed with the length of `CompositeByteBuf#readableBytes`, which is of `int`
type. :)
##########
worker/src/test/java/org/apache/celeborn/service/deploy/worker/storage/PartitionFilesSorterSuiteJ.java:
##########
@@ -102,15 +99,12 @@ public void prepare(boolean largefile) throws IOException {
while (buf2.hasRemaining()) {
channel.write(buf2);
}
+ partitionSize[mapId] = partitionSize[mapId] + batchHeader.length +
mockedData.length;
}
originFileLen = channel.size();
fileInfo.getChunkOffsets().add(originFileLen);
- fileInfo.updateBytesFlushed((int) originFileLen);
Review Comment:
Although IMO, in reality it will not happen because `updateBytesFlushed` is
passed the length of `CompositeByteBuf#readableBytes`, which is of `int` type.
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
