akpatnam25 commented on code in PR #2367:
URL:
https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1520939595
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -330,8 +338,10 @@ public void restoreMetaFromFile(File file) throws
IOException {
.peek(
workerInfo -> {
// Reset worker's network location with current master's
configuration.
- workerInfo.networkLocation_$eq(
-
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
+ if
(workerInfo.networkLocation().equals(NetworkTopology.DEFAULT_RACK)) {
+ workerInfo.networkLocation_$eq(
+
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
Review Comment:
I don't think `workerInfo.networkInfo()` would ever be null since it is set
to DEFAULT_RACK already:
https://github.com/akpatnam25/incubator-celeborn/blob/CELEBORN-1313/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala#L45
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -330,8 +338,10 @@ public void restoreMetaFromFile(File file) throws
IOException {
.peek(
workerInfo -> {
// Reset worker's network location with current master's
configuration.
- workerInfo.networkLocation_$eq(
-
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
+ if
(workerInfo.networkLocation().equals(NetworkTopology.DEFAULT_RACK)) {
+ workerInfo.networkLocation_$eq(
+
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
Review Comment:
Let me know if I am missing something though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
