waitinfuture commented on code in PR #2367:
URL:
https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1521015891
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -330,8 +338,10 @@ public void restoreMetaFromFile(File file) throws
IOException {
.peek(
workerInfo -> {
// Reset worker's network location with current master's
configuration.
- workerInfo.networkLocation_$eq(
-
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
+ if
(workerInfo.networkLocation().equals(NetworkTopology.DEFAULT_RACK)) {
+ workerInfo.networkLocation_$eq(
+
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
Review Comment:
nit: Since this PR aims to reduce the number of resolution in Master, can we
collect WorkerInfos with `DEFAULT_RACK` first then call `
rackResolver.resolveToMap`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
