akpatnam25 commented on code in PR #2367: URL: https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1521832155
########## worker/src/main/scala/org/apache/celeborn/service/deploy/worker/Worker.scala: ########## @@ -293,6 +293,9 @@ private[celeborn] class Worker( private val masterClient = new MasterClient(internalRpcEnvInUse, conf, true) + private val rackResolver = new CelebornRackResolver(conf) + private val networkLocation = rackResolver.resolve(host).getNetworkLocation Review Comment: Do we want to add to constructor? I think it is better to leave as is, since networkLocation is not part of the constructor currently. It is just a field: https://github.com/akpatnam25/incubator-celeborn/blob/CELEBORN-1313/common/src/main/scala/org/apache/celeborn/common/meta/WorkerInfo.scala#L45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
