zwangsheng commented on code in PR #2367:
URL: 
https://github.com/apache/incubator-celeborn/pull/2367#discussion_r1521037009


##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/AbstractMetaManager.java:
##########
@@ -330,8 +338,10 @@ public void restoreMetaFromFile(File file) throws 
IOException {
               .peek(
                   workerInfo -> {
                     // Reset worker's network location with current master's 
configuration.
-                    workerInfo.networkLocation_$eq(
-                        
resolveMap.get(workerInfo.host()).get().getNetworkLocation());
+                    if 
(workerInfo.networkLocation().equals(NetworkTopology.DEFAULT_RACK)) {
+                      workerInfo.networkLocation_$eq(

Review Comment:
   When the Master recovers, is it necessary to reexamine the location? After 
all, we have already set it when register worker.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to