CodingCat commented on code in PR #2366:
URL:
https://github.com/apache/incubator-celeborn/pull/2366#discussion_r1528761854
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Dispatcher.scala:
##########
@@ -154,18 +155,21 @@ private[celeborn] class Dispatcher(nettyEnv: NettyRpcEnv)
extends Logging {
endpointName: String,
message: InboxMessage,
callbackIfStopped: Exception => Unit): Unit = {
+ var data: EndpointData = null
val error = synchronized {
- val data = endpoints.get(endpointName)
+ data = endpoints.get(endpointName)
if (stopped) {
Some(new RpcEnvStoppedException())
} else if (data == null) {
Some(new CelebornException(s"Could not find $endpointName."))
} else {
- data.inbox.post(message)
- receivers.offer(data)
None
}
}
+ if (error.isEmpty) {
Review Comment:
you're right, updated here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
