waitinfuture commented on code in PR #2366:
URL: https://github.com/apache/celeborn/pull/2366#discussion_r1541182027
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Inbox.scala:
##########
@@ -179,13 +198,12 @@ private[celeborn] class Inbox(
}
}
- def post(message: InboxMessage): Unit = inbox.synchronized {
+ def post(message: InboxMessage): Unit = {
Review Comment:
If we use `put` here, we may face busy waiting if exceeds capacity inside
the sync block. This is why I suggest to call `offer` and sleep a while outside
the sync block if false is returned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
