waitinfuture commented on code in PR #2366:
URL: https://github.com/apache/celeborn/pull/2366#discussion_r1541175240
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Inbox.scala:
##########
@@ -179,13 +198,12 @@ private[celeborn] class Inbox(
}
}
- def post(message: InboxMessage): Unit = inbox.synchronized {
+ def post(message: InboxMessage): Unit = {
Review Comment:
You are right that message will not be added after stop is called, but seems
`addMessage` will throw Exception if capacity is exceeded, is this what we want?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
