waitinfuture commented on code in PR #2366:
URL: https://github.com/apache/celeborn/pull/2366#discussion_r1540707956
##########
common/src/main/scala/org/apache/celeborn/common/rpc/netty/Inbox.scala:
##########
@@ -179,13 +198,12 @@ private[celeborn] class Inbox(
}
}
- def post(message: InboxMessage): Unit = inbox.synchronized {
+ def post(message: InboxMessage): Unit = {
Review Comment:
Since `post` is not inside synchronize, it can happen that message be added
into the queue after stop. How about the simple way that each time `post` is to
be invoked, first check if size exceeds capacity and sleep a while if so?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
