SteNicholas commented on code in PR #2629:
URL: https://github.com/apache/celeborn/pull/2629#discussion_r1691051505


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2094,6 +2084,16 @@ object CelebornConf extends Logging {
         "Allowed pattern is: `<host1>:<port1>[,<host2>:<port2>]*`")
       .createWithDefaultString(s"<localhost>:9097")
 
+  val MASTER_ENDPOINTS_RESOLVER: ConfigEntry[String] =
+    buildConf("celeborn.master.endpoints.resolver")
+      .categories("client", "worker")
+      .doc("Resolver class that can be used for dynamically discovering and 
updating the master endpoints. " +

Review Comment:
   @s0nskar, when provided resolver class isn't present in the classpath, could 
you add this check to help users discover this mismatching?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to