s0nskar commented on code in PR #2629:
URL: https://github.com/apache/celeborn/pull/2629#discussion_r1689637992
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2094,6 +2084,16 @@ object CelebornConf extends Logging {
"Allowed pattern is: `<host1>:<port1>[,<host2>:<port2>]*`")
.createWithDefaultString(s"<localhost>:9097")
+ val MASTER_ENDPOINTS_RESOLVER: ConfigEntry[String] =
+ buildConf("celeborn.master.endpoints.resolver")
+ .categories("client", "worker")
+ .doc("Resolver class that can be used for dynamically discovering and
updating the master endpoints. " +
Review Comment:
@SteNicholas How about below description, let me know if these looks ok.
```
val MASTER_ENDPOINTS_RESOLVER: ConfigEntry[String] =
buildConf("celeborn.master.endpoints.resolver")
.categories("client", "worker")
.doc("Resolver class that can be used for discovering and updating the
master endpoints. This allows " +
"users to provide a custom master endpoint resolver implementation.
This is useful in environments " +
"where the master nodes might change due to scaling operations or
infrastructure updates. Clients " +
"need to ensure that provided resolver class should be present in
the classpath.")
.version("0.6.0")
.stringConf
.createWithDefault("org.apache.celeborn.common.client.StaticMasterEndpointResolver")
val MASTER_ENDPOINTS: ConfigEntry[Seq[String]] =
buildConf("celeborn.master.endpoints")
.categories("client", "worker")
.doc("Endpoints of master nodes for celeborn clients to connect.
Client uses resolver provided by" +
s"${MASTER_ENDPOINTS_RESOLVER.key} to resolve the master endpoints.
By default Celeborn uses " +
"`org.apache.celeborn.common.client.StaticMasterEndpointResolver`
which take static master endpoints " +
"as input. Allowed pattern: `<host1>:<port1>[,<host2>:<port2>]*`,
e.g. `clb1:9097,clb2:9098,clb3:9099`. " +
"If the port is omitted, 9097 will be used. If the master endpoints
are not static then users can pass " +
s"custom resolver implementation to discover master endpoints
actively using ${MASTER_ENDPOINTS_RESOLVER.key}.")
.version("0.2.0")
.stringConf
.toSequence
.createWithDefaultString(s"<localhost>:9097")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
