SteNicholas commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1730981466
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HAMasterMetaManager.java:
##########
@@ -109,6 +109,24 @@ public void handleUnRegisterShuffle(String shuffleKey,
String requestId) {
}
}
+ @Override
+ public void batchHandleUnRegisterShuffles(List<String> shuffleKeys, String
requestId) {
+ try {
+ ratisServer.submitRequest(
+ ResourceRequest.newBuilder()
+ .setCmdType(Type.BatchUnRegisterShuffle)
+ .setRequestId(requestId)
+ .setBatchUnregisterShuffleRequest(
+ ResourceProtos.BatchUnregisterShuffleRequest.newBuilder()
+ .addAllShuffleKeys(shuffleKeys)
+ .build())
+ .build());
+ } catch (CelebornRuntimeException e) {
+ LOG.error("Handle unregister shuffle for {} failed!", shuffleKeys, e);
Review Comment:
```suggestion
LOG.error("Batch handle unregister shuffle for {} failed!",
shuffleKeys, e);
```
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/HAMasterMetaManager.java:
##########
@@ -109,6 +109,24 @@ public void handleUnRegisterShuffle(String shuffleKey,
String requestId) {
}
}
+ @Override
+ public void batchHandleUnRegisterShuffles(List<String> shuffleKeys, String
requestId) {
+ try {
+ ratisServer.submitRequest(
+ ResourceRequest.newBuilder()
+ .setCmdType(Type.BatchUnRegisterShuffle)
+ .setRequestId(requestId)
+ .setBatchUnregisterShuffleRequest(
+ ResourceProtos.BatchUnregisterShuffleRequest.newBuilder()
+ .addAllShuffleKeys(shuffleKeys)
+ .build())
+ .build());
+ } catch (CelebornRuntimeException e) {
+ LOG.error("Handle unregister shuffle for {} failed!", shuffleKeys, e);
Review Comment:
```suggestion
LOG.error("Batch handle unregister shuffles for {} failed!",
shuffleKeys, e);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
