zaynt4606 commented on code in PR #2701:
URL: https://github.com/apache/celeborn/pull/2701#discussion_r1739629863
##########
client/src/main/scala/org/apache/celeborn/client/LifecycleManager.scala:
##########
@@ -1583,6 +1590,37 @@ class LifecycleManager(val appUniqueId: String, val
conf: CelebornConf) extends
}
}
+ private def removeBatchExpiredShuffles(): Unit = {
+ val shuffleIds = new util.ArrayList[Integer]()
+ unregisterShuffleTime.keys().asScala.foreach { shuffleId =>
Review Comment:
Thank you for the code review!
I think it would be beneficial to focus solely on the batch processing in
this pull request. This way, we can maintain the same time interval and
condition as before.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
