turboFei commented on code in PR #3026:
URL: https://github.com/apache/celeborn/pull/3026#discussion_r1896915309
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -150,8 +155,17 @@ public ResourceResponse
handleWriteRequest(ResourceProtos.ResourceRequest reques
shuffleFallbackCounts.values().stream().mapToLong(v ->
v).sum(),
appId);
}
+ Map<String, Long> applicationFallbackCounts =
+
request.getAppHeartbeatRequest().getApplicationFallbackCountsMap();
Review Comment:
```
if (CollectionUtils.isNotEmpty(applicationFallbackCounts)) {
LOG.warn(...);
}
```
##########
master/src/main/proto/Resource.proto:
##########
@@ -121,7 +121,9 @@ message AppHeartbeatRequest {
required int64 totalWritten = 3;
required int64 fileCount = 4;
optional int64 shuffleCount = 5;
- map<string, int64> shuffleFallbackCounts = 6;
+ optional int64 applicationCount = 6;
+ map<string, int64> shuffleFallbackCounts = 7;
+ map<string, int64> applicationFallbackCounts = 8;
Review Comment:
ditto
```
map<string, int64> shuffleFallbackCounts = 6;
optional int64 applicationCount = 7;
map<string, int64> applicationFallbackCounts = 8;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
