SteNicholas commented on code in PR #3026:
URL: https://github.com/apache/celeborn/pull/3026#discussion_r1909766236
##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -118,10 +123,24 @@ public <K, V, C> ShuffleHandle registerShuffle(
String appId = SparkUtils.appUniqueId(dependency.rdd().context());
initializeLifecycleManager(appId);
+ if (!registeredApps.contains(appId)) {
Review Comment:
@RexXiong, from my knowledge, there is no case that SparkContext or
ShuffleManager or lifecycleManager have multiple apps. Could you give some
input or thoughts about this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
