RexXiong commented on code in PR #3026:
URL: https://github.com/apache/celeborn/pull/3026#discussion_r1912597824


##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -118,10 +123,24 @@ public <K, V, C> ShuffleHandle registerShuffle(
     String appId = SparkUtils.appUniqueId(dependency.rdd().context());
     initializeLifecycleManager(appId);
 
+    if (!registeredApps.contains(appId)) {
+      registeredApps.add(appId);
+      lifecycleManager.applicationCount().increment();

Review Comment:
   `lifecycleManager.applicationCount().increment()` can move to 
`initializeLifecycleManager`



##########
client-spark/spark-2/src/main/java/org/apache/spark/shuffle/celeborn/SparkShuffleManager.java:
##########
@@ -118,10 +123,24 @@ public <K, V, C> ShuffleHandle registerShuffle(
     String appId = SparkUtils.appUniqueId(dependency.rdd().context());
     initializeLifecycleManager(appId);
 
+    if (!registeredApps.contains(appId)) {

Review Comment:
   So why do we need registeredApps and fallbackApps sets? For Spark, I think 
there should only be a fallback for shuffle.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to