turboFei commented on code in PR #3026:
URL: https://github.com/apache/celeborn/pull/3026#discussion_r1897015659
##########
master/src/main/java/org/apache/celeborn/service/deploy/master/clustermeta/ha/MetaHandler.java:
##########
@@ -150,8 +155,17 @@ public ResourceResponse
handleWriteRequest(ResourceProtos.ResourceRequest reques
shuffleFallbackCounts.values().stream().mapToLong(v ->
v).sum(),
appId);
}
+ Map<String, Long> applicationFallbackCounts =
+
request.getAppHeartbeatRequest().getApplicationFallbackCountsMap();
Review Comment:
Seems not necessary, due we have log the shuffle fallback info with appId.
```
if (CollectionUtils.isNotEmpty(shuffleFallbackCounts)) {
LOG.warn(
"{} shuffle fallbacks in app {}",
shuffleFallbackCounts.values().stream().mapToLong(v ->
v).sum(),
appId);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
