s0nskar opened a new pull request, #3221:
URL: https://github.com/apache/celeborn/pull/3221
<!--
Thanks for sending a pull request! Here are some tips for you:
- Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX]
Your PR title ...'.
- Be sure to keep the PR description updated to reflect all changes.
- Please write your PR title to summarize what this PR proposes.
- If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
Push applicationId as metrics label only if
`celeborn.metrics.pushApplicationId` is enabled.
### Why are the changes needed?
At Uber, We use m3 for monitoring, it tries to make a new series using all
the present metrics label. Having applicationId as a metrics introduces too
much cardinality in `activeconnectioncount` and we are unable to use it, while
it is an useful metric with/without applicationId as label. Similarly for
resourceConsumption, userIdentifier alone can be used.
### Does this PR introduce _any_ user-facing change?
NA
### How was this patch tested?
NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
