turboFei commented on code in PR #3221:
URL: https://github.com/apache/celeborn/pull/3221#discussion_r2062723206
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -5573,6 +5575,16 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val METRICS_PUSH_APPLICATION_ID: ConfigEntry[Boolean] =
Review Comment:
rename the variable name
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -893,6 +893,8 @@ class CelebornConf(loadDefaults: Boolean) extends Cloneable
with Logging with Se
get(METRICS_WORKER_PAUSE_SPENT_TIME_FORCE_APPEND_THRESHOLD)
def metricsJsonPrettyEnabled: Boolean = get(METRICS_JSON_PRETTY_ENABLED)
+ def metricsPushApplicationId: Boolean = get(METRICS_PUSH_APPLICATION_ID)
Review Comment:
rename the function name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
