pan3793 commented on code in PR #3221:
URL: https://github.com/apache/celeborn/pull/3221#discussion_r2062452873
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -5573,6 +5575,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val METRICS_PUSH_APPLICATION_ID: ConfigEntry[Boolean] =
+ buildConf("celeborn.metrics.pushApplicationId")
Review Comment:
`celeborn.metrics.label.applicationId` sgtm.
Please also clarify the side effects of enabling this feature in the `docs`
- application id is considered as a high cardinality label, be careful enabling
it on metrics systems that are not optimized for high cardinality values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
