pan3793 commented on code in PR #3221:
URL: https://github.com/apache/celeborn/pull/3221#discussion_r2062482574
##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -5573,6 +5575,14 @@ object CelebornConf extends Logging {
.booleanConf
.createWithDefault(true)
+ val METRICS_PUSH_APPLICATION_ID: ConfigEntry[Boolean] =
+ buildConf("celeborn.metrics.pushApplicationId")
Review Comment:
but the top 50 application ids are changed over time, right? it also should
be considered as a high cardinality label, for metrics systems like Prometheus,
storing high cardinality labels is a disaster ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
