[
https://issues.apache.org/jira/browse/CLOUDSTACK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006336#comment-15006336
]
ASF GitHub Bot commented on CLOUDSTACK-9063:
--------------------------------------------
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1066#discussion_r44897995
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/Xenserver625Resource.java
---
@@ -55,10 +55,10 @@ public void umountSnapshotDir(final Connection conn,
final Long dcId) {}
@Override
public boolean setupServer(final Connection conn,final Host host) {
- final com.trilead.ssh2.Connection sshConnection = new
com.trilead.ssh2.Connection(_host.getIp(), 22);
+ final com.trilead.ssh2.Connection sshConnection = new
com.trilead.ssh2.Connection(getXenServerHost().getIp(), 22);
try {
sshConnection.connect(null, 60000, 60000);
- if (!sshConnection.authenticateWithPassword(_username,
_password.peek())) {
+ if
(!sshConnection.authenticateWithPassword(getData().getUsername(),
getData().getPasswords().peek())) {
--- End diff --
Extract local variables to avoid this inline method calls.
> CitrixResourceBase refactor
> ---------------------------
>
> Key: CLOUDSTACK-9063
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9063
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Daan Hoogland
>
> https://analysis.apache.org/drilldown/measures/100206?metric=class_complexity
> report on the class is pretty bad. Some trivial changes can be done to
> improve. miracles won't happen but improvements can be made.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
