[
https://issues.apache.org/jira/browse/CLOUDSTACK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15006447#comment-15006447
]
ASF GitHub Bot commented on CLOUDSTACK-9063:
--------------------------------------------
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1066#issuecomment-156976829
I will look at the changes to see if extra unit tests are needed. I have
not introduced any logical changes so far.
I aggree that we should not merge anything called [WIP]... it shall have to
be renamed before merging. It does not contradict the way we have worked lately.
Making it a PR gives the advantage of the automated tests.
> CitrixResourceBase refactor
> ---------------------------
>
> Key: CLOUDSTACK-9063
> URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9063
> Project: CloudStack
> Issue Type: Bug
> Security Level: Public(Anyone can view this level - this is the
> default.)
> Reporter: Daan Hoogland
>
> https://analysis.apache.org/drilldown/measures/100206?metric=class_complexity
> report on the class is pretty bad. Some trivial changes can be done to
> improve. miracles won't happen but improvements can be made.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
