[ 
https://issues.apache.org/jira/browse/CLOUDSTACK-9063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15008232#comment-15008232
 ] 

ASF GitHub Bot commented on CLOUDSTACK-9063:
--------------------------------------------

Github user DaanHoogland commented on the pull request:

    https://github.com/apache/cloudstack/pull/1066#issuecomment-157303792
  
    Wilder, I do run unit test always, but integration test only to the degree 
that they make sense. Even then it is way more convenient to use the check-pr 
script then to have to manually execute all the steps in it, so given low risk 
changes, especially when I don't expect a large number of iterations, it pays 
to create a PR first. Not every one has the luxury of such a splendid testbed 
as sbp has. I enjoy using a bubble but it is only one. Still working on 
creating my own.


> CitrixResourceBase refactor
> ---------------------------
>
>                 Key: CLOUDSTACK-9063
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-9063
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the 
> default.) 
>            Reporter: Daan Hoogland
>
> https://analysis.apache.org/drilldown/measures/100206?metric=class_complexity 
> report on the class is pretty bad. Some trivial changes can be done to 
> improve. miracles won't happen but improvements can be made.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to