[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=597188&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597188
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/21 10:35
Start Date: 15/May/21 10:35
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841637202
@gwlucastrig the code is now compiling. I had to make more design decisions
than I expected to add the parameters. See `ImagingParameters` and the
implementations like `TiffImagingParameters`.
But also take a look at the changes in `ImageFormat` and `ImageFormats` :+1:
Any feedback or suggestions on how to improve it are welcome! Also see
comment above about the getters for the subimage in the TIFF parameter class.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597188)
Time Spent: 2.5h (was: 2h 20m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
