[
https://issues.apache.org/jira/browse/IMAGING-159?focusedWorklogId=597218&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-597218
]
ASF GitHub Bot logged work on IMAGING-159:
------------------------------------------
Author: ASF GitHub Bot
Created on: 15/May/21 13:59
Start Date: 15/May/21 13:59
Worklog Time Spent: 10m
Work Description: gwlucastrig commented on pull request #116:
URL: https://github.com/apache/commons-imaging/pull/116#issuecomment-841663106
I'll look into it. I think, BufferedImage is also part of java awt. I'm
traveling right now
On Sat, May 15, 2021, 8:18 AM Bruno P. Kinoshita ***@***.***>
wrote:
> If those classes are from awt, the issue is that we have a dependency to
> java.desktop (I think that's the java module name) and also cause an issue
> to users of the API that are using Android (as IIUC, there's no awt in
> Android's Java SDK?).
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
>
<https://github.com/apache/commons-imaging/pull/116#issuecomment-841649340>,
> or unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/AEWJDYNES4M3XQCOJIEZN6TTNZRAXANCNFSM4WPUJSLQ>
> .
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 597218)
Time Spent: 3h 20m (was: 3h 10m)
> There should be a Parameters class
> ----------------------------------
>
> Key: IMAGING-159
> URL: https://issues.apache.org/jira/browse/IMAGING-159
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha2
> Reporter: Benedikt Ritter
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Labels: github
> Fix For: 1.0-alpha3
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Currently options for image I/O are defined as Maps. The leads to the problem
> that our code has to validate parameter types when they are used:
> {code:java}
> final Object value = params.get(PARAM_KEY_COMPRESSION);
> if (value != null) {
> if (!(value instanceof Number)) {
> throw new ImageWriteException(
> "Invalid compression parameter, must be numeric: "
> + value);
> }
> compression = ((Number) value).intValue();
> }
> {code}
> This can be simplified if we define a Parameters class that provides
> additional methods like {{public int getInt(String key)}}. The implementation
> could then look up the value from the map through an exception if it is null
> or not a number.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
